Repository navigation
fix(cache): preserve disk cache entries on lookup - #2423
Open
remote-controlled-man wants to merge 2 commits into
Open
remote-controlled-man wants to merge 2 commits into
remote-controlled-man wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LlamaDiskCacheremoves a matching state when reading it, so a later query or reopened cache cannot reuse that prefix. Read the saved state without consuming the entry.Add SQLite-backed regression tests for repeated exact, longer, shorter and divergent-prefix lookups, cache misses, and reopening after a hit, with RAM-cache controls. Keep existing capacity and eviction behavior.
Related historical discussion: #1737 and closed, unmerged #2025. This is a focused fix for destructive reads; no static-cache API or capacity-policy change.
Validation on macOS arm64, Python 3.12.14, using the existing native build and cached model fixtures:
make test: 39 passed, including the upstream real-model fixtures and all 13 new cache cases.make lint: Ruff checks pass and all 30 Python files pass the format check.