[상민] 3-CustomMoviePlayer#21
Open
4-kira wants to merge 4 commits into
Open
Conversation
4-kira
force-pushed
the
Sangmin/3-CustomVideoPlayer
branch
from
34f6fe8 to
60fb3df
Compare
chaeiJeon
reviewed
Apr 4, 2022
| const progress = document.querySelector(".progress"); | ||
| const timestamp = document.querySelector(".timestamp"); | ||
|
|
||
| const PutToPlay = () => { |
Contributor
There was a problem hiding this comment.
성호님 1-FormValidator 코드 리뷰에서 봤는데 함수명에 전치사가 있으면 가독성을 저해한다고 합니다! To를 빼는 방식으로 함수명을 지어 보시는 게 좋을 것 같아요!
| const adjustProgressBar = () => { | ||
| progress.value = (video.currentTime / video.duration) * 100; | ||
|
|
||
| let minutes = String(Math.floor(video.currentTime / 60)).padStart(2, "0"); |
Contributor
There was a problem hiding this comment.
minutes, seconds가 아래에서 바뀌지 않으니 let보다 const가 좋아보입니다!
Contributor
There was a problem hiding this comment.
저도 채이랑 같은 의견입니다^_^!b
| const adjustProgressBar = () => { | ||
| progress.value = (video.currentTime / video.duration) * 100; | ||
|
|
||
| let minutes = String(Math.floor(video.currentTime / 60)).padStart(2, "0"); |
Contributor
There was a problem hiding this comment.
저도 채이랑 같은 의견입니다^_^!b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.