Changed rest calls thread - #294
Open
aarnapant-sap wants to merge 1 commit into
Open
Conversation
shubhamWaghmare-sap
requested changes
Nov 13, 2025
| try { | ||
| getPackageRef(packageName, new NullProgressMonitor()); | ||
| // fetches repository access mode | ||
| getRepositoryAccessMode(); |
Collaborator
There was a problem hiding this comment.
In communication log I checked that there are two calls made to get the externalrepoInfo.
One here and another in the credentials page.
Do we need both ?
| @Override | ||
| public void run(IProgressMonitor monitor) throws InvocationTargetException, InterruptedException { | ||
| try { | ||
| getPackageRef(packageName, new NullProgressMonitor()); |
Collaborator
There was a problem hiding this comment.
If the package check fails and results in an exception, the wizard still tries to open and fails currently in the Credentials page.
Either we need to somehow stop opening of the wizard if there is an exception or continue have this call in main thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed thread for initial externalRepoInfo and packageRefFind call from "main" to "ModalContext"