refactor: use client->action in 19 demo apps#619
Merged
Conversation
…nt()) 23 call sites across 19 demo apps replaced. The new action API is a drop-in shortcut: pass the event name (and optional t_arg) directly instead of nesting _event_client inside follow_up_action. Net -18 LOC, no behavioural change. Raw-JS follow_up_action calls (src/99/...) remain unchanged. abaplint will report "Method action not found" until the abap2UI5 framework branch (claude/brave-goodall-FMD0W) is merged to main, since the dependency clone resolves the framework's default branch. https://claude.ai/code/session_01GaCj1cQU8kZRRmkL7qno6A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces 23
client->follow_up_action( client->_event_client( … ) )nested calls with the newclient->action( … )shortcut across 19 demo apps.follow_up_actioncalls insrc/99/*are intentionally left as-is — they don't fit the new event-only APIDependency
Requires abap2UI5/abap2UI5#2279 (adds
z2ui5_if_client~action). abaplint in this repo pulls the framework from the default branch, so it will reportMethod "action" not founduntil that PR is merged tomain.Example
Test plan
npx abaplint— should report 0 issues once the framework method is availablehttps://claude.ai/code/session_01GaCj1cQU8kZRRmkL7qno6A
Generated by Claude Code