Repository navigation
app-rules: exclude samples-controls apps 649/668/671 from 7bit_ascii - #103
Merged
Merged
Conversation
Syncs the checked copy of the shared app rule set with abap2UI5/abap2UI5 .github/abaplint/app-rules.json after abap2UI5/abap2UI5#2928, whose shared-file gate is red on main until this copy matches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JSQHKWHTrAg6LYE6uGYbky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the checked copy of the shared app rule set in
abaplint.jsoncwith its source,abap2UI5/abap2UI5.github/abaplint/app-rules.json.abap2UI5/abap2UI5#2928 added apps 649, 668 and 671 (the samples-controls ports of
sap.m.p13n.EngineMultipleControllerandsap.f.HeroBanner, which keep their original non-ASCII data) to the7bit_asciiexclusion. This copy was not updated, so theshared-file-gatestep ofcheck_gateson abap2UI5mainis red (run #749):The change is a single line:
|649|668|671is added to the7bit_asciiexclude regex.Checked locally:
npm run check:app-rules: 211 rules here, 211 in the shared set (compared against an abap2UI5 checkout next to this one), match - OKnpm run lint: 0 issues, 259 filesGenerated by Claude Code