Repository navigation
check-app-rules: back to the abap2UI5 source copy - #279
Merged
Merged
Conversation
#278 moved parseJsonc out of scripts/check-app-rules.mjs into lib/jsonc.mjs, but the file is a copy of abap2UI5's .github/shared/check-app-rules.mjs, and abap2UI5's shared-file gate now fails on the difference. The source already has its own inline parseJsonc, so the copy goes back to it verbatim; lib/jsonc.mjs stays for e2e-build.mjs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTHUii3vvZF41gabs3JqHc
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/check-app-rules.mjsis a copy of abap2UI5's.github/shared/check-app-rules.mjs. In #278,parseJsoncwas moved out of the copy intoscripts/lib/jsonc.mjs. Since then, abap2UI5'sshared-filegate fails on every PR (for example abap2UI5/abap2UI5#2952):This PR copies the source back unchanged; it already has its own inline
parseJsonc.lib/jsonc.mjsstays, becausee2e-build.mjsstill uses it.Checks
npm run check:app-rules: 211 of 211 rules, OK.npm run check:sharedagainst this checkout: every copy matches its source, OK.Generated by Claude Code