Repository navigation
Carry the corrected view-chain-layout skill and move the linter to 0.9.0 - #277
Merged
Merged
Conversation
…only by construction, not by a check The abap2UI5 repository is the source of this skill; its paragraph on what the linter checks claimed a verification that @abap2ui5/linter 0.9.0 does not perform. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qid1F6VFxWyQLPvqsr1woq
The linter's control metadata is 1.153.0, and check-pins holds the @openui5/@SAPUI5 runtime pins to the same release. catalogue-derived.json is what 0.9.0 derives (a binding-type-too-new need on app 018). chain-house-layout --fix leaves a comment line at the author's column from 0.9.0 on, so the overview generator now snaps a comment inside a chain to the chain line below it itself - the template emits comments at the template's indent, which 0.8.x happened to shift along with the segment. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qid1F6VFxWyQLPvqsr1woq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review of 2026-10-22.
.claude/skills/view-chain-layout/SKILL.mdbyte-identical to the core's corrected copy. Merge together with abap2UI5/abap2UI5, samples and samples-stack on the same branch name; the core'scheck:sharedis red until all four carry it.@abap2ui5/linter^0.9.0. Its metadata release is 1.153.0, so the 19@openui5/*/@sapui5/*pins follow (check-pinsrule 5);catalogue-derived.jsonregenerated. Linter 0.9.0'schain-house-layout --fixleaves a comment line at its column, soformat-chain.mjsgainedalignChainComments()and the generated overview app is byte-identical to the committed one again.npm test64 pass,npm run gatesgreen (690 files, 0 failing).Generated by Claude Code