Repository navigation
Remove what the old project bar left behind - #168
Merged
Merged
Conversation
The playground's page lost its project bar in #166, but its code and styles stayed: about 500 lines of CSS for the bar, the search box, the two marks and the menu, plus their comments. main.mjs still called setUpExtra() and setUpSearch(), which found nothing to mount. extra.mjs is gone. search-box.mjs stays: the 404 loads it through src/catalogue/search-entry.mjs. AGENTS.md and the design docs say where the bar and the search box still live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmEpRdxrjNxTq4x9J4J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup after #166. That PR removed the playground's project bar, but its styles and setup calls stayed.
What changes
shell.css, about 500 lines removed: rules whose selectors only hit.bar,.bar-nav,.social(s),.extra,.menu*,.when-dark/lightor.search-*, with their comments. None of these classes is on the page any more. Mixed rules such asheader.bar, .toolbarlost their dead half.main.mjs: no moresetUpExtra()andsetUpSearch(); both found nothing to mount.extra.mjsdeleted.search-box.mjs, because the 404 loads it throughsrc/catalogue/search-entry.mjs. The 404 page and its bar (catalogue.css) are unchanged.AGENTS.md,docs/design/sample-catalogue.mdand the comment insearch-entry.mjssay where the bar and the search box still live.No visible change; screenshots of the playground and the 404 match before and after.
Tests
eslint .,typecheckandtest:unit(75/75) are green.check-sizeis green; the published site is 156.49 MB of 220 MB.Generated by Claude Code