Repository navigation
migrate_report runs report2UI5, the user interface only - #66
Merged
Merged
Conversation
abap-cloud-gui renamed its converter report2cloud to report2UI5 (tools/report2ui5) and narrowed it to the user interface of a report: the selection screen, the event blocks, the list, the ALV, the messages and the popups, with the logic copied as it is. - lib/migrate.mjs loads tools/report2ui5/lib and falls back to tools/report2cloud/lib of a 1.0.0 checkout (loadConverter, formerly loadReport2cloud). The checkout is recognized by its report runtime class, not by the converter's path. - The answer no longer carries `release`, the deploy note no longer names tables, and the tool description, `next` and the docs say what the converter does now. - The refused fixture of test/migrate.test.mjs expected a SUBMIT refusal the converter has not made since before 1.0.0 (CI skips the test without a checkout); it refuses SET USER-COMMAND now. The test passes against both the 1.0.0 checkout and the current one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmCuerNTSBiubsAu86Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
abap-cloud-gui renamed its converter report2cloud to report2UI5 (
tools/report2ui5) and narrowed it to the user interface of a report. It converts the selection screen, the event blocks, the list, the ALV, the messages and the popups, and copies the logic as it is. See abap2UI5-addons/abap-cloud-gui#54.Loading the converter
lib/migrate.mjsloadstools/report2ui5/lib. It falls back totools/report2cloud/libfor a 1.0.0 checkout.loadReport2cloudis renamedloadConverter.src/01/z2ui5_cl_cgui_report.clas.abap, the probe inlib/repo-dirs.json, not by the converter's path.The answer
migrate_reportno longer answersrelease, because the converter checks no release state.nexthint, README, AGENTS.md,server.jsonandsmithery.yamldescribe the new scope.Test
SUBMITrefusal, but the converter has mapped SUBMIT since before 1.0.0. CI skips this test without a checkout. The fixture now refusesSET USER-COMMAND.Checks
npm test: 568 pass, 0 fail, 12 skipped, run withABAP_CLOUD_GUI_HOMEset.test/migrate.test.mjspasses against the current abap-cloud-gui and against its 1.0.0 state.npm run check:server-jsonpasses.Generated by Claude Code