Repository navigation
Count a file's lines right in read_example/read_app; refuse a blank docs_search query - #57
Merged
Merged
Conversation
Every abapGit file ends with a line break, and split('\n') read an empty
line after it: `lines` was one too many, and a from_line past the end
answered an empty `source` under a pastEnd saying "its last line is
shown". The paging tests wrote their files without a final newline, so
they never saw it.
sourceLines() drops the break after the last line and puts it back on the
page that ends the file, so the pages still join to the file's exact text.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
docs_search took a query of spaces, searched for no term and answered "no documentation page carries every term of \" \""; it is now refused like a missing query. A pitfalls miss under the default area read "nothing in the all catalogue"; it says "either catalogue" there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-4 bug fixes, found by calling the tools with edge inputs against real sibling checkouts. One commit per fix; both have their line in the (untagged)
## 1.0.0section of CHANGELOG.md, under "Since the 1.0.0 section was first written", so the release workflow's "Unreleased is empty" gate stays satisfied.read_example/read_appcounted one line too many for every abapGit file. Every such file ends with a line break, andsplit('\n')read an empty line after it:lineswas 385 for a 384-line class, and afrom_linepast the end answeredsource: ""under apastEndsaying "its last line is shown". The paging tests wrote their fixtures without a final newline, so they never saw it.sourceLines()drops the break after the last line and puts it back on the page that ends the file, so the pages still join to the exact text. New test intest/paging.test.mjs(fails before the fix).docs_searchwith a query of spaces searched for no term and answered a hint quoting the blanks; it is now refused like a missingquery. Apitfallsmiss under the defaultarearead "nothing in the all catalogue"; it now says "either catalogue". Both pinned in the existing paging tests.Checks:
npm run check(server.json check + 563 tests) passes locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Generated by Claude Code