Repository navigation
Keep the UI5 cache test green beside a samples-controls checkout - #56
Merged
Merged
Conversation
The route handler serves the corpus' local @openui5 packages before the cache, and the test resolved the corpus from the environment: with a samples-controls checkout (npm ci done) beside mcp-server - the setup the README documents - sap-ui-core.js came from disk, no upstream fetch was counted and `npm test` failed on a developer machine while CI, which has no sibling, stayed green. The test now points SAMPLES_CONTROLS_HOME at a fixture corpus without an npm install and restores it afterwards, as the libRoots test beside it does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One test from #55 is not hermetic.
the UI5 route answers a second call from the cacheresolves the corpus from the environment, and the route handler serves the corpus' local@openui5packages before it consults the cache. With a samples-controls checkout (withnpm cidone) beside mcp-server, which is the setup the README documents,sap-ui-core.jscomes from disk. No upstream fetch is counted, andnpm testfails locally with0 !== 1at test/runtime.test.mjs:704. CI has no sibling checkout, so CI stays green.For the length of the test,
SAMPLES_CONTROLS_HOMEnow points at a fixture corpus with no npm install, and the variable is restored afterwards. The libRoots test next to it already works this way. Only the test changes. Nothing ships differently, so there is no changelog line and Unreleased stays empty for the 1.0.0 tag.Release readiness for 1.0.0, checked locally on main (edc42df):
changelog ok: ## 1.0.0 exists, nothing left under Unreleased. Performance: unchanged builds, warm abaplint worker, faster run_app, cached lookups #55 (performance), Update npm dependencies (@modelcontextprotocol/sdk 1.32.1, playwright 1.64.0) and three fixes #52 and Admit @abap2ui5/linter 0.9 in the peer ranges #54 are all filed under## 1.0.0, in "Since the 1.0.0 section was first written".npm run check:server-json:io.github.abap2UI5/mcp-server 1.0.0 = @abap2ui5/mcp-server@1.0.0, 37 environment variables. package.json, package-lock.json and both server.json versions read 1.0.0, and the peer ranges in the lockfile match package.json (>=0.8.0 <0.10.0).npm run check: 561 passed, 4 skipped (network-gated). The one failure is the test this PR fixes.This PR does not block the tag. It can be merged before or after it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Generated by Claude Code