Repository navigation
Make the search box search the whole family - #48
Merged
Merged
Conversation
The box now reads what the docs' index carries since abap2UI5/docs scripts/lib/search-family.mjs: the repositories of both organisations, the tools, the essays, the page for decision makers, the addons, the client API and the framework's classes, beside the docs and the samples. - Best answer: a query that names something - #1234, a class, a method, a repository, a tool - gets it on top - Actions per hit: the source of a sample, README and issues of a repository, a repository's code searched for the query; Right/Left walk them - Scopes: repo:, api:, sample:, doc:, tool:, insight:, why:, addon: - The way out, always in view: the query on GitHub - code of every repository, issues, discussions. Links only, nothing fetched from GitHub - An empty field offers the places to go - /search/?q=… : the search as a page, all results, an address to link; opensearch.xml lets a browser add it as a search engine The matcher is a new copy of the docs' search-engine.js. Nothing is stored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmFLTfBmZJXKPuRQWci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The quiet pill under the greeting now searches the whole family from the docs' index (abap2UI5/docs: "Put the whole family into the search index"): docs, samples, every repository of both orgs, the tools, the essays, the page for decision makers, the addons, the client API and the framework's classes.
#1234, a class, a method, a repository, a toolrepo:,api:,sample:,doc:,tool:,insight:,why:,addon:connect-srcstays'self'/search/?q=…: the search as a page with all results and a shareable address;opensearch.xml+<link rel="search">let a browser add it as a search engineNothing is stored. The markup moved into
src/components/Search.astro(home +/search/).public/search-engine.jsis a fresh copy of the docs' matcher.Works with today's index too (fewer areas, no best answers for repos); merge after the docs PR for the full effect.
Tests
The box test follows the new markup and the engine's new exports; new:
/search/has the box in page mode and the one script, the OpenSearch link on both pages, the template points at/search/?q={searchTerms}.npm run check: 8 pass. Checked in Chromium against a locally built full index: desktop, 390 px, keyboard (actions),/search/?q=round trip.Generated by Claude Code