Repository navigation
The logo beside the greeting is centred on the heading's line - #43
Merged
Merged
Conversation
The logo started at the height of the heading's text and hung 50px below it, so it read as lower than the heading. It rises by half of what it is taller than the line now - 29px at 40px type, computed from the font size so it holds at every width - and its middle is the line's middle: 107px at 1440px, 103px at 820px, 96px on a phone, measured. The row is shorter for it, so the hang into the space below goes, and "Introduction" starts at 199px (204px before). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmFZwmxFekaMfr3Ka5m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logo started at the height of the heading's text and hung 50 px below it, so it looked lower than the heading. It now rises by half of what it is taller than the line:
calc((1.15em - 104px) / 2), which is 29 px at 40 px type. On a phone the same is computed for the 64 px logo. The middle of the logo is now the middle of the heading's line. Measured where the middle falls:The row is shorter for it, so the 24 px hang into the space below goes. "Introduction" starts at 199 px instead of 204 px.
Only
src/styles/global.csschanges.npm run checkpasses: build plus 6 tests.Generated by Claude Code