Repository navigation
The greeting stands where every heading of the family stands, the first group a little higher, the licence line in the foot - #42
Merged
Conversation
… licence line goes to the foot Measured at 1440px: the text of "Welcome to abap2UI5" started at 111px, the headings of Samples, Addons and Insights at 82px - the row centred the text on the 104px logo beside it. The row aligns to the top now, the text starts at 82px (79px on a phone, like the others), the logo beside it at the same height. The About page's heading takes the same size, line height and place (it started at 90px in 32px). "MIT licensed · About" sat in the page under the community row; it is the foot now, one muted line at the bottom of the window however short the page, as on Samples and Addons. CONVENTION.md section 5 said the home page has none; it says every site has one, the home page the shortest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmFZwmxFekaMfr3Ka5m
The 104px logo beside the greeting set the height of the row, 58px more than the heading's line, and the row's 40px margin came on top of that. The logo now hangs 24px into that space (12px on a phone), so "Introduction" starts at 204px instead of 228px (160px instead of 172px on a phone); the greeting and the logo stay where they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmFZwmxFekaMfr3Ka5m
oblomov-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the greeting and the About heading to the same height as the headings on Samples, Addons and Insights, starts the first group a little higher, and makes the licence line a foot. All positions are where the text starts, measured at 1440 px and 390 px wide.
npm run checkpasses: build plus the 6 tests.🤖 Generated with Claude Code
https://claude.ai/code/session_014YZFmFZwmxFekaMfr3Ka5m