Repository navigation
Keep the marked page level with the rest of the breadcrumb - #28
Merged
Merged
Conversation
The current page carries a 2px line and a 1px gap under it, which made its box 3px taller than the other entries; the bar centres its entries, so the marked word sat 1.5px higher than Home and moved whenever the reader went to another page. A margin of -3px takes the line out of the height: the word stays level, only the line is added - as on the home page, Samples and Insights (CONVENTION.md in abap2UI5/abap2UI5.github.io). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmFizjMGgrfvyidBoKd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current page in the breadcrumb carries a 2px line and a 1px gap, which made its box 3px taller than the other entries. The bar centres its entries, so the marked word (
Addons & Tools,se16n, …) sat 1.5px higher thanHomeand moved whenever the reader went to another page.margin-bottom: -3pxtakes the line out of the height: the word stays level, only the line is added - the same change as on the home page (abap2UI5/abap2UI5.github.io#45, with CONVENTION.md), abap2UI5/insights#8 and abap2UI5/samples-site#16, where it was measured in the browser (every entry's text at the same top; before, the marked one 1.5px higher). The rule here is the same, character for character, in the same flex bar. Not built locally - CI builds and tests this PR.Generated by Claude Code