Repository navigation
Expose Matroska attachments; prepare 3.1.0 - #3
Merged
Merged
Conversation
Fansub MKVs ship the fonts used by ASS subtitles as AttachedFile elements. Parse them so callers can preserve and address the attachments (ffmpeg t:<n> streams) when remuxing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attachments>AttachedFileinto a new publicVideoMetadata.attachments: [AttachmentStream](file name, MIME type, description, payload size, UID).indexmatches ffmpeg'st:<n>attachment stream numbering.Motivation: Aagedal Media Converter needs the attachment count to preserve ASS subtitle fonts when remuxing MKVs with metadata stripped (aagedal/Aagedal-Media-Converter#64).
-map_metadata -1drops the filename/mimetype tags the Matroska muxer requires, so they must be restored per attachment index.Testing
testMKVAttachmentsDecode(synthetic EBML, including a skipped incomplete entry).Scripts/verify-release.sh 3.1.0passed locally (1679 library tests, CLI tests, archive build).🤖 Generated with Claude Code