Repository navigation
Conversation
`dynptr!(&'a (dyn Trait + Send + Sync))` panicked with "expected `dyn` not found" because syn parses the referent as Type::Paren rather than Type::TraitObject. Since `&'a dyn Trait + Send` isn't valid type syntax, there was no way to name a Send/Sync DynRef with the macro. Strip Type::Paren and Type::Group (produced by `$t:ty` in macro_rules!) from both the outer type and the pointee before matching. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dynptr!(&'a (dyn Trait + Send + Sync))panicked with "expecteddynnot found" because syn parses the referent as Type::Paren rather than Type::TraitObject. Since&'a dyn Trait + Sendisn't valid type syntax, there was no way to name a Send/Sync DynRef with the macro.Strip Type::Paren and Type::Group (produced by
$t:tyin macro_rules!) from both the outer type and the pointee before matching.Written by Claude (sorry), but it makes a lot of sense to me.
I state that I was not able to sign ECA with my GitHub private email,
since I wouldn't want to disclose my public email for this particular commit,
and that therefore I grant the permission to copy/merge my PR if accepted