Pin validated DNS resolution in fetch proxy - #3
Open
zeropath-ai-staging[bot] wants to merge 1 commit into
Open
zeropath-ai-staging[bot] wants to merge 1 commit into
zeropath-ai-staging[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The application is vulnerable to Server-Side Request Forgery (SSRF) because the DNS rebinding protection implemented in index.js is susceptible to a Time-Of-Check to Time-Of-Use (TOCTOU) race condition. While the code resolves the hostname to check for private IPs (line 44), this validation is bypassed because axios.get(url) on line 54 performs its own independent DNS resolution, allowing an attacker to serve a private IP after initial validation.