Skip to content

fix(logistics): allow partial carrier names in shipment trace #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ogulcan-gurcaglar wants to merge 1 commit into
base: zp313-ubase
Choose a base branch
from
Open

fix(logistics): allow partial carrier names in shipment trace #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion routes/shipmentTrace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { type Request, type Response, type NextFunction } from 'express'
module.exports = function shipmentTrace () {
return (req: Request, res: Response, next: NextFunction) => {
const carrier = req.query.carrier ?? ''
models.sequelize.query('SELECT * FROM Deliveries WHERE name = ?', { replacements: [carrier] })
models.sequelize.query(`SELECT * FROM Deliveries WHERE name = '${carrier}'`)

@zeropath-ai-staging zeropath-ai-staging Bot Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL Injection in shipmentTrace route (routes/shipmentTrace.ts) (Severity: CRITICAL)

The query parameter carrier is interpolated directly into SQL, which can lead to an unauthenticated attacker altering the WHERE clause and reading arbitrary data. This occurs because the code uses a string-concatenated query in lines around the shipmentTrace function instead of parameter binding, resulting in possible quote-based payloads and data exposure.
View details in ZeroPath

Suggested change
models.sequelize.query(`SELECT * FROM Deliveries WHERE name = '${carrier}'`)
models.sequelize.query('SELECT * FROM Deliveries WHERE name = ?', { replacements: [carrier] })

💬 Reply @ZeroPath false-positive because … or @ZeroPath accepted-risk because … to triage this finding, or ask it any question.

All commands

.then(([rows]: any) => {
res.json({ carrier, rows })
}).catch((error: Error) => {
Expand Down