Repository navigation
Deps(go): chi 5.4.0 for the X-Forwarded-For client IP advisory - #59
Merged
Merged
Conversation
Dependabot alert #1 (GHSA, medium) reports that chi up to 5.3.2 lets a client spoof its IP through X-Forwarded-For in ClientIPFromXFF. This server never calls ClientIPFromXFF or middleware.RealIP: server.go deliberately skips RealIP, and security.go honours X-Forwarded-For only when the immediate peer is a configured trusted proxy. So the advisory cannot be reached here, but the vulnerable code still ships in the binary and the alert stays open, so chi moves to its first fixed version, 5.4.0, and nothing else moves. go vet and go test pass unchanged. The Nix vendorHash follows in the next commit, from the nix check's reported hash.
The nix check reported the vendored modules' hash after the chi bump (got sha256-3ZvpQhiC...); release.json carries it so the Nix package builds again.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves github.com/go-chi/chi/v5 from 5.2.5 to 5.4.0, its first fixed version for Dependabot alert #1 (ClientIPFromXFF X-Forwarded-For spoofing, medium). The server never calls ClientIPFromXFF or middleware.RealIP (server.go skips RealIP on purpose; security.go trusts X-Forwarded-For only from a configured proxy), so the advisory is not reachable, but the code ships and the alert stays open. Only chi moves; go vet and go test pass. vendorHash follows from the nix check. Ships in server 2.80.1 today (Adib: "we need all these fixes to be release today with the rest").