Repository navigation
Conversation
A view that scrolls both ways drew a solid white 10px square in its bottom-right corner, where the vertical and horizontal scrollbars meet. In a dark theme it was the brightest thing on screen: rgb(255,255,255) against Gruvbox dark's rgb(30,32,33). The 2.80.0 phone walk found it on the Kanban board with lanes, and a check of the desktop build found the same square on wide database grids. The global stylesheet styles ::-webkit-scrollbar, its track and its thumb, but never ::-webkit-scrollbar-corner. Once a page styles the scrollbar, Chromium draws the corner as a custom part too, and a corner with no style of its own paints white. The rule was missing long before 2.80.0; lanes only put one more two-way scroller on a screen people look at all day. The corner is now transparent beside the global track, so it shows whatever sits behind the scroller, the same as the track does. That is the page background in every theme, dark or light, with no new token. It is one rule in app-core, so desktop, the self-hosted web app and the phones all get it; the phone shells already carry an equal rule in their own mobile.css for 1.35.0 / 1.1.51, which this makes redundant but harmless. The thumb and track are left as they were. Checked in the built app with both stores isolated, on a Kanban board with Lanes: Priority (1792 by 8762 inside 654 by 432) and a 24 column, 80 row CSV database (3099 by 2721 inside 654 by 476). In Gruvbox dark every one of the corner's 400 device pixels reads rgb(30,32,33), the page's own colour, on both views. Deleting just this rule in the same session turns all 400 white, and restoring it brings the page colour back. Gruvbox light reads rgb(250,242,204), the page again, where the missing rule left a fainter white square on the cream page. Tests: the stylesheet has a ::-webkit-scrollbar-corner rule with a transparent background (red without the rule).
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same-day patch for 2.80.0 (Adib: "we need all these fixes to be release today with the rest").
Local gates on 06ab9d6: npm ci, typecheck, test:run uncached (shared 2298, app-core 4619+1, desktop 1351+5, quicklook 18), build:prod, the three smoke suites, pack + packaged launch check (2.80.1, page target, rendered), hazard scan, dash lint.