Repository navigation
Conversation
…t has a key row Settings, Typography, Covers described itself as "How a note's cover shows, and the Unsplash key the cover picker searches with." on every host, but the phones have no Unsplash bridge, so they show no key row and no Unsplash tab: the description promised a setting that is not there. Found walking the iPhone 1.34.0 release build. The description now follows the same check the key row uses (unsplashKeySupported): with the bridge it reads as before, without it "How a note's cover shows." Test: the Covers section's text without the Unsplash bridge leaves the key out, and with it names the key (fails on the previous text).
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1010 before the 2.79.0 tag: the Covers settings section no longer names the Unsplash key on hosts without the Unsplash bridge (the phones), found walking the iPhone 1.34.0 release build. One commit, 44954fa, with a test that fails on the old text.
The release gates rerun on this commit (typecheck, test:run, build:prod, signed pack, packaged launch check, the three Vim smoke suites).