Skip to content

Fix(tui): a new note opens in the editor always, despite the set default mode #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adibhanna merged 1 commit into from
Nov 1, 2026
Merged

Fix(tui): a new note opens in the editor always, despite the set default mode #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions internal/tui/newnote_mode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package tui

import (
"testing"

"github.com/ZenNotes/tui/internal/vault"
)

// A freshly created note is entered in insert mode, so it must show the
// editor even when the default pane mode is preview.
func TestCreateNoteOpensInEditMode(t *testing.T) {
a, _ := newFeatureTestApp(t)
a.prefs.DefaultPaneMode = string(modePreview)
a.createNote(vault.FolderInbox, "Fresh", "", nil, true)
tb := a.activeTab()
if tb == nil {
t.Fatal("no active tab")
}
if tb.mode != modeEdit {
t.Fatalf("new note opened in mode %q, want edit", tb.mode)
}
}
6 changes: 6 additions & 0 deletions internal/tui/noteops.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ func (a *App) createNote(folder vault.NoteFolder, title, subpath string, body *s
a.addNoteToIndex(meta)
if open {
a.openNote(meta.Path, true)
// The new note is entered for typing, so show the editor whatever
// the default pane mode is.
if t := a.activeTab(); t != nil && t.view == nil && t.path == meta.Path {
t.mode = modeEdit
a.layout()
}
a.withLoadedBuffer(meta.Path, func(buf *noteBuffer) {
buf.ed.GotoLine(buf.ed.LineCount())
if a.prefs.VimMode {
Expand Down
Loading