Skip to content

Make toBuilder and formBuiler APIs more unified #6

Closed
Closed
Make toBuilder and formBuiler APIs more unified#6
Assignees
winterland1989

Description

@4eUeP
4eUeP
opened on Feb 17, 2021

For now, if we want to build a Builder from bytes, int ... we can find these functions under Z.Data.Builder, but the CBytes's toBuilder is under Z.Data.CBytes.

What about putting these builder functions in one place? @winterland1989

Activity

  1. 4eUeP
    assigned
    winterland1989
    on Feb 17, 2021

  2. winterland1989 commented on Feb 17, 2021

    @winterland1989
    winterland1989
    on Feb 17, 2021
    Contributor

    CBytes is a more independent module, so I didn’t want to make a reversed dependency. And if we move them to Builder then we have to explain why it may write invalid UTF8 bytes, which is somewhat duplicated.

  3. 4eUeP
    closed this as completedon Feb 18, 2021
  4. ZHaskell
    locked and limited conversation to collaborators on Feb 18, 2021
  5. winterland1989
    added a commit that references this issue on Jun 9, 2021

    fix #6

    7b28ed3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions