Skip to content

Open source internal implementation - #5

Open
kononovk wants to merge 6 commits into
mainfrom
kononovk/open_source_internal_implementation
Open

Open source internal implementation#5
kononovk wants to merge 6 commits into
mainfrom
kononovk/open_source_internal_implementation

Conversation

@kononovk

@kononovk kononovk commented May 27, 2023

Copy link
Copy Markdown
Member

Purpose

  • First implementation of all asynchronous primitives.
  • Add tests, examples
  • Fix CI
  • Changes in README (add badges and useful links)

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@kononovk
kononovk requested a review from MBkkt as a code owner May 27, 2023 17:30
@kononovk kononovk added devops DevOps tasks enhancement New feature or request labels May 27, 2023
@github-actions

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5099995144

  • 65 of 75 (86.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-13.9%) to 86.111%

Changes Missing Coverage Covered Lines Changed/Added Lines %
include/ione/context.hpp 21 23 91.3%
src/context.cpp 33 41 80.49%
Totals Coverage Status
Change from base Build 5009095869: -13.9%
Covered Lines: 113
Relevant Lines: 124

💛 - Coveralls

@codecov

codecov Bot commented May 27, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.66%. Comparing base (8a92d55) to head (0b6fd09).

Files with missing lines Patch % Lines
src/context.cpp 80.48% 8 Missing ⚠️
include/ione/context.hpp 91.30% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main       #5       +/-   ##
============================================
- Coverage   100.00%   86.66%   -13.34%     
============================================
  Files            1        3        +2     
  Lines            2       75       +73     
============================================
+ Hits             2       65       +63     
- Misses           0       10       +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops DevOps tasks enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant