fix: keep event bubbles working after cancelling print - #749
Open
rahulyadav911 wants to merge 1 commit into
Open
fix: keep event bubbles working after cancelling print#749rahulyadav911 wants to merge 1 commit into
rahulyadav911 wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe calendar print handler now uses a non-deep clone, preserves hidden body elements, hides only visible non-script elements during printing, and restores their original visibility afterward. ChangesCalendar print workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/js/default-calendar.js`:
- Around line 419-424: Update the print cleanup sequence after window.print() in
the calendar print handler to remove the simcal-print-calendar class from body
before restoring $divToPrint and $toHide. Preserve the existing clone removal
and hidden-element restoration behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9aff498d-cc3a-4056-b920-4a55c810fd7c
📒 Files selected for processing (1)
assets/js/default-calendar.js
Akhill2020
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:: Print Overlay Persists After Cancelling Print Dialog
Description::
Before: Print cloned the calendar with all its tip data (clone(true)), hid the page, then after cancel showed every body child again. That pulled dormant qTip layers back on top of the calendar, so some events stopped responding to hover/click.
After: We clone without that tip data, and we only put back what we actually hid. Tips that were meant to stay hidden stay hidden, so events work again after Cancel.
Touched: assets/js/default-calendar.js
Before:: Link
After:: Link
Summary by CodeRabbit