test: enforce generated model contracts#17
Merged
Conversation
Signed-off-by: kriptoburak <kriptoburak@users.noreply.github.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
furkanerday
approved these changes
Jul 24, 2026
furkanerday
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the complete diff, description, discussion, repository policies, public contracts, relevant tests, required checks, and commit sign-offs at 9ac4a2d. All required checks pass, no unresolved threads remain, and I found no blocking issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenSSF Evidence
The generated-inclusive JaCoCo report now measures:
The maintained-source report remains above policy:
Verification
./scripts/lint./scripts/test --rerun-tasks(1,346 tests, 0 failures, 0 errors, 0 skipped)./scripts/coverage --rerun-tasks./scripts/audit(license policy and OSV scan)uvx reuse lint(REUSE 3.3 compliant)./scripts/check-reproducible(15 byte-identical Maven artifacts)Review Notes
This test-only change protects generated SDK contracts across future OpenAPI regenerations. Another human must review this nontrivial maintainer-authored change before merge.
Note
Add contract test suite for generated API models, params, and enums
com.x_twitter_scraper.api.modelsat test runtime.JsonField,additionalProperties, equality/hashCode/toString, and validation contracts for generated models; checks builder/getter behavior for params; and asserts correct known/unknown/invalid semantics for enum wrappers.Macroscope summarized 9ac4a2d.