Repository navigation
Fix packet buffer drop - #81
Open
jflarin-oti wants to merge 3 commits into
Open
jflarin-oti wants to merge 3 commits into
jflarin-oti wants to merge 3 commits into
Conversation
added 3 commits
August 24, 2026 18:10
…lid+tlast+tready) drop_busy is asserted, but drop_in_prog is RESET. So ram_addra_checkpoint is not updated and packet is not read out. However the size is still written in the size_fifo_inst because size_fifo_wr_en is masked by dropped. This produces a mismatch between the packet data and the size fifo.
…lid+tlast+tready) drop_busy is asserted, but drop_in_prog is RESET. So ram_addra_checkpoint is not updated and packet is not read out. However the size is still written in the size_fifo_inst because size_fifo_wr_en is masked by dropped. This produces a mismatch between the packet data and the size fifo. Signed-off-by: Jean-Francois Larin <jflarin@orthogone.com>
…ti/open-nic-shell into fix_packet_buffer_drop
Author
|
Note that this is my first pull request on github. If there is something incorrect with this PR, please educate me. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug has been observed on the bench on a forked version of OpenNic.
The bug generates message similar to this on the dmesg:
onic: QDMA error active: idx=21 reg=C2H_ERR_STAT(0xaf0) mask=0x00000002 - Packet length mismatch error
onic: QDMA error active: idx=35 reg=C2H_FATAL_ERR_STAT(0xaf8) mask=0x00000002 - Fatal Len mismatch error
There is a bug when the drop input happens EXACTLY on last input (tvalid+tlast+tready)
drop_busy is asserted, but drop_in_prog is RESET.
So ram_addra_checkpoint is not updated and packet is not read out, as it should for a dropped packet.
However the size is still written in the size_fifo_inst because size_fifo_wr_en is masked by dropped signal (ie: the signal not set when drop occurs only on the tvalid+tready+tlast). This produces a mismatch between the packet data and the size fifo.