fix(upgrade): resolve latest version from FDS to match install download source#1237
Open
qiaozongming wants to merge 1 commit into
Open
fix(upgrade): resolve latest version from FDS to match install download source#1237qiaozongming wants to merge 1 commit into
qiaozongming wants to merge 1 commit into
Conversation
| /\/+$/, | ||
| "", | ||
| ) | ||
| const version = (yield* text(["curl", "-fsSL", `${base}/releases/latest`])).trim().replace(/^v/, "") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
mimo upgrade(curl 安装方式)分两步:releases/latest重定向取版本号https://mimo.xiaomi.com/install,该脚本已改为从 FDS 下载(feat(release): publish and install release artifacts via Xiaomi FDS #1212)两步来源不一致:版本检查走 GitHub(国内慢/可能不可达),下载走 FDS。
改动
把 curl 方式的版本检查也改为读 FDS 的
releases/latest(install 脚本写入、下载时读取的同一文件),与下载源统一。基址可用MIMO_FDS_BASE覆盖,与 install 脚���对齐。其他安装方式(npm/pnpm/bun)不变,仍走各自 registry。
Test plan
mimo upgrade能从 FDS 解析到最新版本并升级bun typecheck通过(已验证)