Skip to content

fix-model-endpoint-save - Fixed model endpoint save so that it uses the azure_environment variable to determine default management cloud. - #10

Open
chadpalmer wants to merge 4 commits into
Developmentfrom
fix-model-endpoint-save
Open

chadpalmer wants to merge 4 commits into
Developmentfrom
fix-model-endpoint-save

Conversation

@chadpalmer

Copy link
Copy Markdown
Collaborator

This pull request addresses a bug where model endpoint saves could incorrectly persist the auth.management_cloud field as public when the cloud selector was hidden in the Admin UI. The update ensures that the management cloud setting always aligns with the AZURE_ENVIRONMENT variable when the field is not user-editable, preventing token audience and scope mismatches for government environments. The release notes and functional tests have also been updated to reflect and verify this behavior.

Bug Fixes: Model Endpoint Management Cloud Enforcement

  • Enforced management_cloud alignment with AZURE_ENVIRONMENT in normalize_model_endpoints, ensuring the field cannot be set to an incorrect default when the admin UI does not expose cloud selection. This includes new helper functions _get_default_management_cloud_from_environment and _is_management_cloud_user_editable in functions_settings.py. [1] [2]
  • Added a focused functional test (test_model_endpoint_management_cloud_default.py) to verify that hidden admin UI paths cannot persist incorrect management_cloud defaults.

Documentation

  • Updated release notes in release_notes.md to describe the bug fix and the new normalization guard for model endpoint management cloud enforcement.

Versioning

  • Bumped application version to 0.241.008 in config.py.

…he azure_environment variable to determine default management cloud.
@chadpalmer
chadpalmer requested a review from Xeelee33 May 29, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant