Repository navigation
feat: introduce Commenter interface - #633
boekkooi-impossiblecloud wants to merge 1 commit into
Conversation
|
@boekkooi-impossiblecloud Hey, sorry for the late response. Could you provide a use case where users want to use a different comment style? |
|
Hey @XSAM No worries, I'm already thankful you took the time to review this PR 😄. In my case I needed a way to add specific comments to the end of all prepare queries which contains specific environment information (e.g. we have a shared set of repositories that are used by multiple workers and we needed to trace which worker called which prepared queries) but we also need to keep the tracing info for query calls. As the use case is a bit more custom I think the interface makes sense but if you have a better Idea I'm game 😄 Thanks again and have a great day |
This allows users of the library to use their own custom commenter. This can be useful when different comments are prefered for Queries and Prepared statements.
ccc2a53 to
e25866e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
=======================================
+ Coverage 89.8% 90.0% +0.2%
=======================================
Files 16 16
Lines 599 613 +14
=======================================
+ Hits 538 552 +14
Misses 61 61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Good day!
This PR introduces the Commenter interface which allows users to use their own custom SQL commenter.
This can be useful when different comments are preferred for SQL statements.
Thanks for having a look and please let me know what you think.
Have a great weekend.