fixed missing type validation on vetoed parameter in feature handler#7583
Open
harshitgupta62 wants to merge 1 commit into
Open
fixed missing type validation on vetoed parameter in feature handler#7583harshitgupta62 wants to merge 1 commit into
harshitgupta62 wants to merge 1 commit into
Conversation
harshitgupta62
force-pushed
the
fix-vetoed-type-validation
branch
from
b4090a8 to
4919297
Compare
harshitgupta62
force-pushed
the
fix-vetoed-type-validation
branch
from
4919297 to
d040617
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6757
Adds an isBool() type check on the
vetoedparameter in doFeaturebefore calling asBool(). Previously, sending a non-boolean value
(e.g. a string or null) for
vetoedcould either throw an unhandledexception or silently coerce to false, accidentally triggering
unVeto() instead of returning a proper validation error.
Returns rpcINVALID_PARAMS when the type check fails, consistent
with the existing pattern in this codebase.