Skip to content

feat: Add custom conventional commit check#131

Open
mvadari wants to merge 2 commits into
XRPLF:mainfrom
mvadari:custom-conventional-commits
Open

feat: Add custom conventional commit check#131
mvadari wants to merge 2 commits into
XRPLF:mainfrom
mvadari:custom-conventional-commits

Conversation

@mvadari

@mvadari mvadari commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This PR adds a customizable version of the PR title check (separate from the existing check)

Copilot AI review requested due to automatic review settings June 18, 2026 20:23
@mvadari mvadari changed the title add custom conventional commit check feat: Add custom conventional commit check Jun 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new reusable workflow that allows callers to customize the allowed Conventional Commit “type” prefixes for PR titles, and refactors the existing check-pr-title.yml workflow to delegate to this new customizable workflow while preserving the current default type list.

Changes:

  • Refactor existing PR title check workflow to call a new reusable workflow.
  • Add check-pr-title-custom.yml reusable workflow with an input for allowed Conventional Commit types.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/check-pr-title.yml Converts the existing reusable workflow into a thin wrapper that calls the new customizable workflow with the current default type list.
.github/workflows/check-pr-title-custom.yml Adds a new reusable workflow that runs the conventional-commit title validator and an additional capitalization check, with configurable allowed types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +36 to +40
run: |
if [[ ! "${TITLE}" =~ ^[a-z]+:\ [\[A-Z] ]]; then
echo "Error: Title must start with an uppercase letter after the prefix."
exit 1
fi
echo "Error: Title must start with an uppercase letter after the prefix."
exit 1
fi
uses: ./.github/workflows/check-pr-title-custom.yml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not work when launched outside of this repo - I'm not 100% sure, but it might not resolve to the .github of this repo, when being launched from the outside world

Please, investigate, and repo might need to be explicitly specified.
In that case, it would also need to specift a hash commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants