chore(spawn-jdk): make ClassPathTests robust when JVM is launched on module path only#17
Merged
chore(spawn-jdk): make ClassPathTests robust when JVM is launched on module path only#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldCreateSystemClassPath previously assumed java.class.path is always non-empty, causing it to fail when the JVM is launched purely on the module path (e.g. under spin). The test now reads java.class.path and branches: asserts empty when the system property is empty, otherwise applies the existing non-empty checks.
shouldTreatClassPathAsAPathSet had the same fragility — it sourced test paths from ClassPath.inherited(), which throws if the inherited classpath is empty. Replaced with user.home, a stable path that's always present.