You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
WordPress.tv: Remove the Flash-era VideoPress footer script - #1230
It set wmode on the VideoPress Flash player, which no longer exists. jQuery isn’t loaded on WordPress.tv anymore either (none of the scripts on the home page define it), so the script throws ReferenceError: jQuery is not defined on every page view. That’s the console error the ticket reports.
This removes the callback and its hook. The subtitle upload failure in the ticket’s title was a problem with the reporter’s TTML file (see comment:3), and the upload flow itself was reworked in https://meta.trac.wordpress.org/changeset/15316.
The theme printed an inline script on every page that set the wmode
parameter on the VideoPress Flash player through jQuery.VideoPress.
The Flash player is long gone, and jQuery isn't loaded on WordPress.tv
anymore, so the script only threw "jQuery is not defined" in the
console on every page view.
Fixes #7143.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
The theme no longer registers videopress_flash_params() on wp_footer. The method that output JavaScript to set VideoPress’s Flash player wmode to opaque was removed.
Changes: VideoPress Flash parameter injection
Layer / File(s)
Summary
Remove the footer callback wordpress.tv/public_html/wp-content/themes/wptv2/functions.php
The theme no longer registers the footer callback or defines the method that set the VideoPress Flash player wmode to opaque.
This removes an obsolete footer script that caused a console error on WordPress.tv. No concrete merge risk was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the main change: removing the obsolete VideoPress Flash footer script.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://meta.trac.wordpress.org/ticket/7143
The wptv2 theme hooks
videopress_flash_params()intowp_footer, which prints this on every page:It set
wmodeon the VideoPress Flash player, which no longer exists. jQuery isn’t loaded on WordPress.tv anymore either (none of the scripts on the home page define it), so the script throwsReferenceError: jQuery is not definedon every page view. That’s the console error the ticket reports.This removes the callback and its hook. The subtitle upload failure in the ticket’s title was a problem with the reporter’s TTML file (see comment:3), and the upload flow itself was reworked in https://meta.trac.wordpress.org/changeset/15316.
Testing
Uncaught ReferenceError: jQuery is not defined.view-source:no longer containsjQuery.VideoPress.🤖 Generated with Claude Code
Summary by CodeRabbit