Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
The parent theme unsets the footer background on 404s so its charcoal body shows through, but the support theme paints the 404 body white, leaving the white footer text on a white background. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
obenland
force-pushed
the
fix/support-404-footer-background
branch
from
November 10, 2026 20:53
daf83e8 to
c3e79f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On support 404 pages (e.g. https://de.wordpress.org/support/article/site-editor-patterns/), the global footer has no background, so its white text sits on a white page.
wporg-parent-2021's 404 styles paint
body.error404charcoal and unset the footer's background (body.error404 .wp-block-wporg-global-footer { background: unset }), relying on the body showing through. wporg-support-2024 overrides the 404 body to white, which removes the color the footer depended on.This restores the footer's own background (
--wp-global-header--background-color, set by the global footer block) on the support theme's 404 page. The rule has the same specificity as the parent's and loads after it.Rebuilt
build/style.cssandbuild/style-rtl.css; the only compiled change is the new rule.Testing
🤖 Generated with Claude Code