Skip to content

Administration: Deduplicate Custom Fields dropdown options #15893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salvatorecorsi wants to merge 1 commit into
base: trunk
Choose a base branch
from
+40 −0
Open

Administration: Deduplicate Custom Fields dropdown options #15893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/wp-admin/includes/template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,7 @@ function meta_form( $post = null ) {
}

if ( $keys ) {
$keys = array_unique( $keys );
natcasesort( $keys );
}
?>
Expand Down
39 changes: 39 additions & 0 deletions tests/phpunit/tests/admin/includesTemplate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,45 @@ public function test_get_inline_data_contains_term_if_show_ui_is_false_but_show_
$this->expectOutputRegex( '/<div class="tags_input" id="wptests_tax_1_' . $post->ID . '">Test<\/div>/' );
}

/**
* @ticket 54339
*
* @covers ::meta_form
*/
public function test_meta_form_shows_each_filtered_key_once() {
wp_set_current_user( self::$editor_id );
$post = self::factory()->post->create_and_get();

add_filter(
'postmeta_form_keys',
static function () {
return array( 'item10', 'CaseKey', 'shared', '_protected' );
}
);
add_filter(
'postmeta_form_keys',
static function ( $keys ) {
return array_merge( $keys, array( 'shared', 'item2', 'casekey', 'denied' ) );
},
20
);
add_filter( 'auth_post_meta_denied', '__return_false' );

ob_start();
meta_form( $post );
$output = ob_get_clean();

$processor = new WP_HTML_Tag_Processor( $output );
$keys = array();
while ( $processor->next_tag( 'OPTION' ) ) {
$keys[] = $processor->get_attribute( 'value' );
}

$this->assertContains( 'CaseKey', $keys );
$this->assertContains( 'casekey', $keys );
$this->assertSame( array( '#none#', 'casekey', 'casekey', 'item2', 'item10', 'shared' ), array_map( 'strtolower', $keys ) );
}

public function test_add_meta_box() {
global $wp_meta_boxes;

Expand Down
Loading