Skip to content

Widgets: Prevent an infinite loop in wp_widget_rss_process(). #15892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rejaulalomkhan wants to merge 1 commit into
base: trunk
Choose a base branch
from
+63 −2
Open

Widgets: Prevent an infinite loop in wp_widget_rss_process(). #15892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wp-includes/widgets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1822,8 +1822,8 @@ function wp_widget_rss_process( $widget_rss, $check_feed = true ) {
if ( is_wp_error( $rss ) ) {
$error = $rss->get_error_message();
} else {
$link = esc_url( strip_tags( $rss->get_permalink() ) );
while ( stristr( $link, 'http' ) !== $link ) {
$link = esc_url( strip_tags( (string) $rss->get_permalink() ) );
while ( ! empty( $link ) && stristr( $link, 'http' ) !== $link ) {
$link = substr( $link, 1 );
}

Expand Down
61 changes: 61 additions & 0 deletions tests/phpunit/tests/widgets/wpWidgetRss.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,67 @@ public static function data_url_happy_path() {
);
}

/**
* Ensures that processing a feed returns when its channel link is not an HTTP URL.
*
* @ticket 62341
* @covers ::wp_widget_rss_process
* @dataProvider data_wp_widget_rss_process_channel_link
*
* @param string $channel_link Markup of the channel link in the feed.
* @param string $expected Expected link.
*/
public function test_wp_widget_rss_process_channel_link( $channel_link, $expected ) {
add_filter(
'pre_http_request',
static function () use ( $channel_link ) {
return array(
'headers' => new WpOrg\Requests\Utility\CaseInsensitiveDictionary(
array( 'Content-Type' => 'application/rss+xml; charset=UTF-8' )
),
'body' => '<?xml version="1.0" encoding="UTF-8"?><rss version="2.0"><channel><title>Feed</title>' . $channel_link . '</channel></rss>',
'response' => array(
'code' => 200,
'message' => 'OK',
),
'cookies' => array(),
'filename' => null,
);
}
);

$result = wp_widget_rss_process(
array(
'url' => 'https://example.org/feed/',
'items' => 5,
)
);

$this->assertSame( $expected, $result['link'] );
}

/**
* Data provider.
*
* @return array[]
*/
public static function data_wp_widget_rss_process_channel_link() {
return array(
'HTTPS URL' => array(
'channel_link' => '<link>https://example.com/</link>',
'expected' => 'https://example.com/',
),
'FTP URL' => array(
'channel_link' => '<link>ftp://example.com/</link>',
'expected' => '',
),
'no link element' => array(
'channel_link' => '',
'expected' => '',
),
);
}

public function mocked_rss_response() {
$single_value_headers = array(
'Content-Type' => 'application/rss+xml; charset=UTF-8',
Expand Down
Loading