Skip to content

Ensure canvas cells are always square #15890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tellthemachines wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Ensure canvas cells are always square #15890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/wp-includes/block-supports/layout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,14 @@ function wp_get_layout_style( $selector, $layout, $has_block_gap_support = false
if ( $should_output_grid_rows ) {
$layout_styles[] = array(
'selector' => $selector,
'declarations' => array( 'grid-template-rows' => 'repeat(' . $row_count . ', minmax(1rem, auto))' ),
/*
* The aspect ratio gives empty rows a height, so cells are roughly square.
* Rows still grow if their content is taller.
*/
'declarations' => array(
'grid-template-rows' => 'repeat(' . $row_count . ', minmax(1rem, 1fr))',
'aspect-ratio' => $column_count . ' / ' . $row_count,
),
);
}

Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/block-supports/layout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1658,7 +1658,7 @@ public function test_get_layout_style_with_numeric_string_grid_counts() {
);

$this->assertSame(
'.wp-layout{grid-template-columns:repeat(3, minmax(0, 1fr));grid-template-rows:repeat(2, minmax(1rem, auto));}',
'.wp-layout{grid-template-columns:repeat(3, minmax(0, 1fr));grid-template-rows:repeat(2, minmax(1rem, 1fr));aspect-ratio:3 / 2;}',
$layout_styles
);
}
Expand Down
Loading