Skip to content

Connectors: Load the filesystem credentials modal on the Connectors screen. - #15889

Open
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:65223-connectors-filesystem-credentials
Open

t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:65223-connectors-filesystem-credentials

Conversation

@t-hamano

Copy link
Copy Markdown
Contributor

Backport of the PHP part of WordPress/gutenberg#78367. Supersedes #13953.

When the filesystem method requires credentials that are not stored (for example, FS_METHOD is ftpext), installing a plugin from Settings > Connectors fails because the REST plugins endpoint rejects the request with fs_unavailable. With the Gutenberg PR, the Connectors JS falls back to wp.updates.installPlugin() in that case, which shows the "Connection Information" modal. This PR loads what that fallback needs on the Connectors screen: the updates script, the credentials modal, and the admin notice templates, the same way Plugins > Add Plugin does.

This has no effect until the Connectors JS from the Gutenberg PR is synced to core.

Testing Instructions

Requires the Connectors JS from the Gutenberg PR.

  1. Add define( 'FS_METHOD', 'ftpext' ); to wp-config.php without storing FTP credentials.
  2. Go to Settings > Connectors and click Install for a connector whose plugin is not installed.
  3. The "Connection Information" modal opens, and valid credentials install and activate the plugin.

Trac ticket: https://core.trac.wordpress.org/ticket/65223

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Porting the PHP change from the Gutenberg PR and drafting this PR description; reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

…creen.

Co-Authored-By: Claude <noreply@anthropic.com>
@t-hamano
t-hamano marked this pull request as ready for review November 11, 2026 04:02
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant