Skip to content

Twenty Twenty-One: Respect custom text of the more tag in the continue reading link - #15887

Open
irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:fix/52683-twentytwentyone-custom-more-text
Open

irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:fix/52683-twentytwentyone-custom-more-text

Conversation

@irozum

@irozum irozum commented Nov 10, 2026

Copy link
Copy Markdown

Twenty Twenty-One's the_content_more_link filter always built the link from the theme's default "Continue reading" text, discarding the custom text from <!--more Custom text--> or the More block's custom text.

Changes

  • twenty_twenty_one_continue_reading_link() now accepts the filter's $more_link_element and $more_link_text arguments, and the filter is registered with 2 accepted args.
  • When the post content has custom more text, the link uses it (escaped) followed by the visually hidden post title, which keeps the screen reader context.
  • Otherwise the default theme text is used, unchanged. Custom text is detected from the post content rather than by comparing against the theme default, because templates that call the_content() with no argument receive core's default text.
  • Both new parameters default to '', so direct calls without arguments still work.

Notes

  • Detection scans the whole post_content, so a custom <!--more--> on a later page of a <!--nextpage--> post is also picked up. In practice the more tag sits on page 1.
  • The translator comment part of the original patch landed separately in #55564 and is not touched here.

Tests

  • New Tests_Theme_TwentyTwentyOneContinueReadingLink covers custom text, default text, escaping, and an end-to-end get_the_content() check.

Trac ticket: https://core.trac.wordpress.org/ticket/52683

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Implementation, tests, and PR description.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props irozum.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant