Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
On multisite, the plugin and theme editors only exist in the network admin, and
wp-admin/plugin-editor.php/theme-editor.phpredirect there without the query string.wp_edit_theme_plugin_file()ran its fatal-error loopback againstadmin_url(), so the redirect droppedwp_scrape_keyandwp_scrape_nonce. No scrape result was printed, and valid PHP edits were reverted withloopback_request_failed.Changes
network_admin_url()for the plugin and theme editor loopback URLs. On a single site it returnsadmin_url(), so nothing changes there.Tests
test_should_send_editor_loopback_to_network_admin_on_multisite, which fails before the fix.Known limitation, not addressed
Trac ticket: https://core.trac.wordpress.org/ticket/45755
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Implementation, tests, and PR description.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code