Repository navigation
Conversation
The latest version backports several cryptographic boundary and validation fixes: * Ed25519 signature verification now rejects public keys of small order. * ChaCha20 now throws an exception when the block counter overflows, instead of reusing the keystream. * The SecretStream rekey check now uses the full 32-bit counter. * Ristretto255 now throws an exception when inverting a zero scalar. * `ParagonIE_Sodium_File::box_open()` and related methods now only write to the destination file after the ciphertext has been authenticated. This also restores the trailing newline at the end of `src/Core/Curve25519.php`, which was lost in r63397, so that all bundled files are identical to the upstream release. References: * [https://github.com/paragonie/sodium_compat/releases/tag/v1.24.2 sodium_compat 1.24.2 release notes] * [paragonie/sodium_compat@v1.24.1...v1.24.2 Full list of changes in sodium_compat 1.24.2] Follow-up to r55699, r58752, r58753, r60787, r60905, r61419, r63397. Props desrosj. Fixes #66650. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Y86gx1T9qpKZuJWesSGiZ
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Updates the bundled sodium_compat library from 1.24.1 to 1.24.2, the latest release on the v1.x branch that WordPress uses.
This update is a hardening release.
Trac ticket: https://core.trac.wordpress.org/ticket/66650
WordPress only loads sodium_compat when the native Sodium extension isn't available (
! function_exists( 'sodium_crypto_box' )inwp-includes/compat.php). These fixes only take effect on those sites.How this follows previous updates
lib/,namespaced/andsrc/, plusautoload.php,autoload-php7.php,composer.jsonandLICENSE. That's 108 files, and upstream's tests and build tooling are left out.src/Core/Curve25519.php, which was missing its trailing newline in r63397. This PR restores the newline, so all 108 files now match upstream v1.24.2 byte for byte.Follow-up tolist.Testing
php -lpasses on the changed files under PHP 8.6.0-dev.vendor/bin/phpcs --standard=phpcompat.xml.dist src/wp-includes/sodium_compat/is clean.vendor/bin/phpcs src/wp-includes/sodium_compat/is clean.Use of AI Tools
🤖 Generated with Claude Code
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.