Repository navigation
Tests: Cover deprecated feature-level selectors in WP_Theme_JSON - #15849
Closed
shail-mehta wants to merge 4 commits into
Closed
shail-mehta wants to merge 4 commits into
shail-mehta wants to merge 4 commits into
Conversation
shail-mehta
changed the title
WP_Theme_JSONWP_Theme_JSON
shail-mehta
marked this pull request as ready for review
November 10, 2026 05:20
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
t-hamano
approved these changes
Nov 10, 2026
t-hamano
left a comment
t-hamano
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Setting the Gutenberg PR aside, I think this test is worth adding to core.
wporg-sync
pushed a commit
that referenced
this pull request
Nov 10, 2026
Adds a test that registers a dedicated block with feature-level selectors defined via `__experimentalSelector` and verifies the generated color and typography styles. Developed in #15849 Props shailu25, wildworks. Fixes #66640. git-svn-id: https://develop.svn.wordpress.org/trunk@65376 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Nov 10, 2026
Adds a test that registers a dedicated block with feature-level selectors defined via `__experimentalSelector` and verifies the generated color and typography styles. Developed in WordPress/wordpress-develop#15849 Props shailu25, wildworks. Fixes #66640. Built from https://develop.svn.wordpress.org/trunk@65376 git-svn-id: http://core.svn.wordpress.org/trunk@64515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: #66640
Backports for: #64345
What?
Adds dedicated test coverage for deprecated feature-level selectors defined via
__experimentalSelector.Why?
The test should not depend on the Calendar block’s metadata because Gutenberg PR WordPress/gutenberg#64345 replaces its deprecated color selector with stable block selectors.
How?
__experimentalSelector.Testing Instructions
Use of AI Tools