Repository navigation
Bundled Themes: Update Ipsum for 7.2 Beta 5 #15845
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 24.18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| === Contributing to Ipsum === | ||
|
|
||
| Ipsum is developed at https://github.com/WordPress/ipsum. Changes made there are synced to WordPress core, so please open issues and pull requests in that repository. | ||
|
|
||
| = Minifying CSS = | ||
|
|
||
| Ipsum has a single stylesheet `style.css` which is enqueued in addition to the global styles coming from core. On a normal production site, when `SCRIPT_DEBUG` is disabled, then the minified version `style.min.css` will be enqueued instead, unless `style.css` has changed since `style.min.css` was built. If you make a change to `style.css`, you'll need to re-minify the `style.min.css` using the built-in npm build tool. As always, it is preferable to use the Site Editor to supply Additional CSS instead of directly editing the theme stylesheet. | ||
|
|
||
| Installation instructions | ||
|
|
||
| 1. Using a command line interface, go to the “ipsum” directory `cd /my-computer/local-wordpress-install/src/wp-content/themes/ipsum`. | ||
|
|
||
| 2. Type `npm install` into the command line, and press the [return] key, to install all Node.js dependencies. | ||
|
|
||
| 3. The dependencies may take a few minutes to download but once it completes, you’re done. | ||
|
|
||
| Usage instructions | ||
|
|
||
| 1. After making a change to the `style.css` file, run `npm run build` from within the theme directory to regenerate `style.min.css` with your new changes. | ||
|
|
||
| 2. You can also “watch” the theme directory for CSS changes and re-minify the CSS anytime a change occurs by running: `npm run watch`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,14 +48,35 @@ function ipsum_add_theme_support() { | |
| * @return void | ||
| */ | ||
| function ipsum_enqueue_styles() { | ||
| $style_path = get_parent_theme_file_path( 'style.css' ); | ||
| $style_min_path = get_parent_theme_file_path( 'style.min.css' ); | ||
|
|
||
| /* | ||
| * Use the minified stylesheet, unless script debugging is on or style.css | ||
| * has changed since style.min.css was built. That keeps edits made in the | ||
| * Theme File Editor working: saving style.css makes it the newer file. | ||
| */ | ||
| if ( | ||
| SCRIPT_DEBUG | ||
| || ! file_exists( $style_min_path ) | ||
| || ( filemtime( $style_path ) > filemtime( $style_min_path ) ) | ||
|
Contributor
There was a problem hiding this comment. As this is in the build step for WP-Dev, I think we can replace this with a simple The process for uploading themes to the theme repo is to use the zips generated by the build steps in wp-dev so it shouldn't be a problem as it too contains the compressed file, see this action run. |
||
| ) { | ||
| $src = 'style.css'; | ||
| } else { | ||
| $src = 'style.min.css'; | ||
| } | ||
|
|
||
| // Register theme stylesheet. | ||
| wp_register_style( | ||
| 'ipsum-style', | ||
| get_parent_theme_file_uri( $src ), | ||
| array(), | ||
| wp_get_theme( get_template() )->get( 'Version' ) | ||
| ); | ||
|
|
||
| // Let WordPress inline the stylesheet, so it is not a render-blocking request. | ||
| wp_style_add_data( 'ipsum-style', 'path', get_parent_theme_file_path( $src ) ); | ||
|
|
||
| // Enqueue theme stylesheet. | ||
| wp_enqueue_style( 'ipsum-style' ); | ||
| } | ||
|
|
@@ -69,21 +90,29 @@ function ipsum_enqueue_styles() { | |
| * | ||
| * @since Ipsum 1.0 | ||
| * | ||
| * @param array<string, mixed> $source_args Block binding source arguments. Unused. | ||
| * @param WP_Block $block_instance The block instance. | ||
| * @return string|null The call to action text, an empty string when comments | ||
| * are closed, or null to keep the block's original content | ||
| * when there is no post. | ||
| */ | ||
| function ipsum_comments_cta_binding( $source_args, $block_instance ) { | ||
| unset( $source_args ); // Unused, but must be accepted to get the block instance. | ||
|
|
||
| $post_id = $block_instance->context['postId'] ?? null; | ||
| $post = get_post( is_numeric( $post_id ) ? (int) $post_id : null ); | ||
| if ( ! $post ) { | ||
| return null; | ||
| } | ||
|
|
||
| if ( ! comments_open( $post ) ) { | ||
| return ''; | ||
| } | ||
|
|
||
| $post_title = wp_strip_all_tags( get_the_title( $post ) ); | ||
| $has_title = ! empty( $post_title ); | ||
|
|
||
| if ( get_comments_number( $post ) > 0 ) { | ||
| $text = $has_title | ||
| ? sprintf( | ||
| /* translators: %s: Post title. */ | ||
|
|
@@ -101,7 +130,7 @@ function ipsum_comments_cta_binding( $source_args, $block_instance ) { | |
| : __( 'Be the first to comment', 'ipsum' ); | ||
| } | ||
|
|
||
| return '<a href="' . esc_url( get_comments_link( $post ) ) . '">' . wp_kses_post( $text ) . '</a>'; | ||
| } | ||
| endif; | ||
|
|
||
|
|
@@ -133,8 +162,9 @@ function ipsum_register_block_bindings() { | |
| * | ||
| * @since Ipsum 1.0 | ||
| * | ||
| * @param array<string, array<string, string>> $default_template_types The default template types, keyed by | ||
| * slug, each with a title and description. | ||
| * @return array<string, array<string, string>> The template types, with the sidebar variants added. | ||
| */ | ||
| function ipsum_sidebar_template_types( $default_template_types ) { | ||
| $default_template_types['index-sidebar'] = array( | ||
|
|
@@ -166,6 +196,14 @@ function ipsum_register_pattern_categories() { | |
| 'description' => __( 'Full page layouts, ready to be applied to a page.', 'ipsum' ), | ||
| ) | ||
| ); | ||
|
|
||
| register_block_pattern_category( | ||
| 'ipsum_post-format', | ||
| array( | ||
| 'label' => _x( 'Post formats', 'Block pattern category', 'ipsum' ), | ||
| 'description' => __( 'Layouts for post formats, like audio and link posts.', 'ipsum' ), | ||
| ) | ||
| ); | ||
| } | ||
| endif; | ||
| add_action( 'init', 'ipsum_register_pattern_categories' ); | ||
|
|
@@ -182,12 +220,14 @@ function ipsum_register_pattern_categories() { | |
| * | ||
| * @since Ipsum 1.0 | ||
| * | ||
| * @param array<string, mixed> $metadata Metadata for the block type being registered. | ||
| * @return array<string, mixed> The block metadata, with ARIA label support on the Search block. | ||
| */ | ||
| function ipsum_search_aria_label_support( $metadata ) { | ||
| if ( isset( $metadata['name'] ) && 'core/search' === $metadata['name'] ) { | ||
| $supports = isset( $metadata['supports'] ) && is_array( $metadata['supports'] ) ? $metadata['supports'] : array(); | ||
| $supports['ariaLabel'] = true; | ||
| $metadata['supports'] = $supports; | ||
| } | ||
| return $metadata; | ||
| } | ||
|
|
@@ -201,6 +241,10 @@ function ipsum_search_aria_label_support( $metadata ) { | |
| * The Evening code style keeps the Evening palette's literals on purpose, | ||
| * so the block reads as a dark slab under every style variation. | ||
| * | ||
| * Each style's CSS is an inline style, as in the default themes. Row Hover | ||
| * can't move to styles/blocks/, because a theme.json css string cannot hold | ||
| * its at-rules and selector lists. | ||
| * | ||
| * @since Ipsum 1.0 | ||
| * | ||
| * @return void | ||
|
|
@@ -223,6 +267,86 @@ function ipsum_register_block_styles() { | |
| 'inline_style' => '.wp-block-site-logo.is-style-sharp{border-radius:0;}', | ||
| ) | ||
| ); | ||
|
|
||
| /* | ||
| * Pins the part to the bottom of the viewport, so it belongs at the root | ||
| * of the template. It keeps to its content's width at the inline end, so | ||
| * the rest of the band doesn't block clicks on the page. The editors also | ||
| * need the override in editor-style.css. | ||
| */ | ||
| register_block_style( | ||
| 'core/template-part', | ||
| array( | ||
| 'name' => 'sticky-bottom', | ||
| 'label' => _x( 'Pinned to Bottom', 'Block style label', 'ipsum' ), | ||
| 'inline_style' => ' | ||
| .wp-block-template-part.is-style-sticky-bottom { | ||
| position: sticky; | ||
| inset-block-end: 0; | ||
| z-index: 10; | ||
| width: fit-content; | ||
| margin-inline-start: auto; | ||
| }', | ||
| ) | ||
| ); | ||
|
|
||
| /* | ||
| * Outlines the Search button until it is hovered, focused or pressed, when | ||
| * the global button states take back over. A theme.json css string would | ||
| * wrap this in :where() and only tie with the global button styles. | ||
| */ | ||
| register_block_style( | ||
| 'core/search', | ||
| array( | ||
| 'name' => 'outline', | ||
| 'label' => _x( 'Outline', 'Block style label', 'ipsum' ), | ||
| 'inline_style' => ' | ||
| .wp-block-search.is-style-outline .wp-block-search__button.wp-element-button:not(:hover):not(:focus):not(:active) { | ||
| background-color: var(--wp--preset--color--base); | ||
| border: 1px dotted var(--wp--preset--color--contrast); | ||
| color: var(--wp--preset--color--contrast); | ||
| }', | ||
| ) | ||
| ); | ||
|
|
||
| /* | ||
| * Hovering any part of a post row colors the whole row and tilts its | ||
| * featured image. Targets the row's child blocks, since the Group spans | ||
| * the full band. Needs each post's blocks wrapped in one Group. | ||
| */ | ||
| register_block_style( | ||
| 'core/post-template', | ||
| array( | ||
| 'name' => 'hover-together', | ||
| 'label' => _x( 'Row Hover', 'Block style label', 'ipsum' ), | ||
| 'inline_style' => ' | ||
| .wp-block-post-template.is-style-hover-together .wp-block-post > .wp-block-group, | ||
| .wp-block-post-template.is-style-hover-together .wp-block-post > .wp-block-group a { | ||
| transition: color 0.15s ease-out; | ||
| } | ||
|
|
||
| .wp-block-post-template.is-style-hover-together .wp-block-post > .wp-block-group:has(> :hover), | ||
| .wp-block-post-template.is-style-hover-together .wp-block-post > .wp-block-group:has(> :hover) a { | ||
| color: var(--wp--preset--color--accent-3); | ||
| } | ||
|
|
||
| @media (prefers-reduced-motion: no-preference) { | ||
| @keyframes tilt-settle { | ||
| 35% { | ||
| transform: rotate(-1deg); | ||
| } | ||
|
|
||
| 100% { | ||
| transform: rotate(0deg); | ||
| } | ||
| } | ||
|
|
||
| .wp-block-post-template.is-style-hover-together .wp-block-post > .wp-block-group:has(> :hover) .wp-block-post-featured-image img { | ||
| animation: tilt-settle 0.5s ease-out; | ||
| } | ||
| }', | ||
| ) | ||
| ); | ||
| } | ||
| endif; | ||
| add_action( 'init', 'ipsum_register_block_styles' ); | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little unclear which of the two repos "that repository" refers too. I think everything changes post release (unless there are plans otherwise for this theme) so not a big deal.