Skip to content

Users: Avoid defaulting new user's display name, nickname, or nicename to an email address #15400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robelsust wants to merge 4 commits into
base: trunk
Choose a base branch
from
+542 −12
Open

Users: Avoid defaulting new user's display name, nickname, or nicename to an email address #15400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d217d0
Users: Avoid defaulting new user's display name, nickname, or nicenam…
robelsust Nov 3, 2026
4b5e494
Merge branch 'trunk' into fix/66446-user-email-display-name-privacy
robelsust Nov 3, 2026
f8cce97
Users: Keep profile dropdown unchanged per review feedback on #66446.
robelsust Nov 3, 2026
53264a2
Users: Anonymize email-login accounts with unique random suffix and c…
robelsust Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/js/_enqueues/admin/user-profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,13 +512,17 @@
if ( select.length ) {
$('#first_name, #last_name, #nickname').on( 'blur.user_profile', function() {
var dub = [],
isEmail = $('#user_login').attr( 'data-is-email' ) === 'true',
inputs = {
display_nickname : $('#nickname').val() || '',
display_username : $('#user_login').val() || '',
display_firstname : $('#first_name').val() || '',
display_lastname : $('#last_name').val() || ''
};

if ( ! isEmail ) {
inputs.display_username = $('#user_login').val() || '';
}

if ( inputs.display_firstname && inputs.display_lastname ) {
inputs.display_firstlast = inputs.display_firstname + ' ' + inputs.display_lastname;
inputs.display_lastfirst = inputs.display_lastname + ' ' + inputs.display_firstname;
Expand Down
5 changes: 4 additions & 1 deletion src/wp-admin/user-edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@
<table class="form-table" role="presentation">
<tr class="user-user-login-wrap">
<th><label for="user_login"><?php _e( 'Username' ); ?></label></th>
<td><input type="text" name="user_login" id="user_login" aria-describedby="user-login-description" value="<?php echo esc_attr( $profile_user->user_login ); ?>" readonly="readonly" class="regular-text ltr" /> <span class="description" id="user-login-description"><?php _e( 'Usernames cannot be changed.' ); ?></span></td>
<td><input type="text" name="user_login" id="user_login" aria-describedby="user-login-description" value="<?php echo esc_attr( $profile_user->user_login ); ?>"<?php echo is_email( $profile_user->user_login ) ? ' data-is-email="true"' : ''; ?> readonly="readonly" class="regular-text ltr" /> <span class="description" id="user-login-description"><?php _e( 'Usernames cannot be changed.' ); ?></span></td>
</tr>

<?php if ( ! IS_PROFILE_PAGE && ! is_network_admin() && current_user_can( 'promote_user', $profile_user->ID ) ) : ?>
Expand Down Expand Up @@ -551,7 +551,10 @@
<?php
$public_display = array();
$public_display['display_nickname'] = $profile_user->nickname;

if ( ! is_email( $profile_user->user_login ) ) {
$public_display['display_username'] = $profile_user->user_login;
}

if ( ! empty( $profile_user->first_name ) ) {
$public_display['display_firstname'] = $profile_user->first_name;
Expand Down
42 changes: 32 additions & 10 deletions src/wp-includes/user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2198,6 +2198,8 @@ function validate_username( $username ) {
* @since 5.3.0 The `user_activation_key` field can be passed to `$userdata`.
* @since 5.3.0 The `spam` field can be passed to `$userdata` (Multisite only).
* @since 5.9.0 The `meta_input` field can be passed to `$userdata` to allow addition of user meta data.
* @since 7.2.0 Default `display_name`, `nickname`, and `user_nicename` avoid using an email address
* when `$user_login` is an email address.
*
* @global wpdb $wpdb WordPress database abstraction object.
*
Expand All @@ -2208,13 +2210,15 @@ function validate_username( $username ) {
* @type string $user_pass The plain-text user password for new users.
* Hashed password for existing users.
* @type string $user_login The user's login username.
* @type string $user_nicename The URL-friendly user name.
* @type string $user_nicename The URL-friendly user name. Default is a URL-safe version
* of the user's login, or a generated slug (user-{random})
* if the login is an email address.
* @type string $user_url The user URL.
* @type string $user_email The user email address.
* @type string $display_name The user's display name.
* Default is the user's username.
* @type string $nickname The user's nickname.
* Default is the user's username.
* @type string $display_name The user's display name. Default is the user's username,
* or 'User {random}' if the username is an email address.
* @type string $nickname The user's nickname. Default is the user's username,
* or 'User {random}' if the username is an email address.
* @type string $first_name The user's first name. For new users, will be used
* to build the first part of the user's display name
* if `$display_name` is not specified.
Expand Down Expand Up @@ -2370,12 +2374,22 @@ function wp_insert_user( $userdata ) {
return new WP_Error( 'invalid_username', __( 'Sorry, that username is not allowed.' ) );
}

$email_login_suffix = '';
if ( is_email( $user_login ) ) {
$email_login_suffix = bin2hex( random_bytes( 4 ) );
}

/*
* If a nicename is provided, remove unsafe user characters before using it.
* Otherwise build a nicename from the user_login.
* If updating an email-login user and no nicename is provided, preserve existing nicename.
* Otherwise build a nicename from a random slug (if login is an email) or the user_login.
*/
if ( ! empty( $userdata['user_nicename'] ) ) {
$user_nicename = sanitize_user( $userdata['user_nicename'], true );
} elseif ( $update && is_email( $user_login ) && ! empty( $old_user_data->user_nicename ) ) {
$user_nicename = $old_user_data->user_nicename;
} elseif ( is_email( $user_login ) ) {
$user_nicename = 'user-' . $email_login_suffix;
} else {
$user_nicename = mb_substr( $user_login, 0, 50 );
}
Expand Down Expand Up @@ -2463,7 +2477,11 @@ function wp_insert_user( $userdata ) {
// Store values to save in user meta.
$meta = array();

$nickname = empty( $userdata['nickname'] ) ? $user_login : $userdata['nickname'];
if ( empty( $userdata['nickname'] ) ) {
$nickname = is_email( $user_login ) ? 'User ' . $email_login_suffix : $user_login;
} else {
$nickname = $userdata['nickname'];
}

/**
* Filters a user's nickname before the user is created or updated.
Expand Down Expand Up @@ -2498,7 +2516,7 @@ function wp_insert_user( $userdata ) {

if ( empty( $userdata['display_name'] ) ) {
if ( $update ) {
$display_name = $user_login;
$display_name = is_email( $user_login ) ? 'User ' . $email_login_suffix : $user_login;
} elseif ( $meta['first_name'] && $meta['last_name'] ) {
$display_name = sprintf(
/* translators: 1: User's first name, 2: Last name. */
Expand All @@ -2510,6 +2528,8 @@ function wp_insert_user( $userdata ) {
$display_name = $meta['first_name'];
} elseif ( $meta['last_name'] ) {
$display_name = $meta['last_name'];
} elseif ( is_email( $user_login ) ) {
$display_name = 'User ' . $email_login_suffix;
} else {
$display_name = $user_login;
}
Expand Down Expand Up @@ -2581,8 +2601,10 @@ function wp_insert_user( $userdata ) {
* @type string $user_pass The user's password.
* @type string $user_email The user's email.
* @type string $user_url The user's url.
* @type string $user_nicename The user's nice name. Defaults to a URL-safe version of user's login.
* @type string $display_name The user's display name.
* @type string $user_nicename The user's nice name. Defaults to a URL-safe version of user's login,
* or a generated slug (user-{random}) if the login is an email address.
* @type string $display_name The user's display name. Defaults to the user's username, or
* 'User {random}' if the username is an email address.
* @type string $user_registered MySQL timestamp describing the moment when the user registered. Defaults to
* the current UTC timestamp.
* }
Expand Down
Loading
Loading