Skip to content

Code Quality: Document theme JSON resolver cached properties as nullable #15385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
westonruter wants to merge 1 commit into from
Closed

Code Quality: Document theme JSON resolver cached properties as nullable #15385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/wp-includes/class-wp-theme-json-resolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,31 +47,31 @@ class WP_Theme_JSON_Resolver {
* Container for data coming from core.
*
* @since 5.8.0
* @var WP_Theme_JSON
* @var WP_Theme_JSON|null
*/
protected static $core = null;

/**
* Container for data coming from the blocks.
*
* @since 6.1.0
* @var WP_Theme_JSON
* @var WP_Theme_JSON|null
*/
protected static $blocks = null;

/**
* Container for data coming from the theme.
*
* @since 5.8.0
* @var WP_Theme_JSON
* @var WP_Theme_JSON|null
*/
protected static $theme = null;

/**
* Container for data coming from the user.
*
* @since 5.9.0
* @var WP_Theme_JSON
* @var WP_Theme_JSON|null
*/
protected static $user = null;

Expand All @@ -80,7 +80,7 @@ class WP_Theme_JSON_Resolver {
* that holds the user data.
*
* @since 5.9.0
* @var int
* @var int|null
*/
protected static $user_custom_post_type_id = null;

Expand All @@ -89,7 +89,7 @@ class WP_Theme_JSON_Resolver {
*
* @since 5.8.0 As `$theme_json_i18n`.
* @since 5.9.0 Renamed from `$theme_json_i18n` to `$i18n_schema`.
* @var array
* @var array|null
*/
protected static $i18n_schema = null;

Expand Down
30 changes: 0 additions & 30 deletions tests/phpstan/baselines/assign.propertyType.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,36 +53,6 @@ parameters:
identifier: assign.propertyType
count: 1
path: ../../../src/wp-includes/class-wp-term-query.php
-
message: '#^Static property WP_Theme_JSON_Resolver\:\:\$blocks \(WP_Theme_JSON\) does not accept null\.$#'
identifier: assign.propertyType
count: 1
path: ../../../src/wp-includes/class-wp-theme-json-resolver.php
-
message: '#^Static property WP_Theme_JSON_Resolver\:\:\$core \(WP_Theme_JSON\) does not accept null\.$#'
identifier: assign.propertyType
count: 1
path: ../../../src/wp-includes/class-wp-theme-json-resolver.php
-
message: '#^Static property WP_Theme_JSON_Resolver\:\:\$i18n_schema \(array\) does not accept null\.$#'
identifier: assign.propertyType
count: 1
path: ../../../src/wp-includes/class-wp-theme-json-resolver.php
-
message: '#^Static property WP_Theme_JSON_Resolver\:\:\$theme \(WP_Theme_JSON\) does not accept null\.$#'
identifier: assign.propertyType
count: 1
path: ../../../src/wp-includes/class-wp-theme-json-resolver.php
-
message: '#^Static property WP_Theme_JSON_Resolver\:\:\$user \(WP_Theme_JSON\) does not accept null\.$#'
identifier: assign.propertyType
count: 1
path: ../../../src/wp-includes/class-wp-theme-json-resolver.php
-
message: '#^Static property WP_Theme_JSON_Resolver\:\:\$user_custom_post_type_id \(int\) does not accept null\.$#'
identifier: assign.propertyType
count: 1
path: ../../../src/wp-includes/class-wp-theme-json-resolver.php
-
message: '#^Property WP_User\:\:\$roles \(array\<string\>\) does not accept array\<string, bool\>\.$#'
identifier: assign.propertyType
Expand Down
Loading