[t-hamano]

Addresses the following point in comment:27:

As WP_Secrets_Config_Key_Provider::KNOWN_PLACEHOLDER only checks the English value, non English sites may end up with secrets encrypted with a known value. Review wp_salt() for how this is handled for the other constants.

Trac ticket: https://core.trac.wordpress.org/ticket/66187

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting the change, the test, and this description. I reviewed the change.

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, rejaulalomkhan, ericmann.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[t-hamano]

@rejaulalomkhan, thanks for taking the time to review this PR. However, your review reads as if AI simply put the code diff into words. One purpose of a code review is to actually look for flaws in the diff, or to suggest an approach you think would be better. Using AI to assist with reviews is fine, but AI cannot be the sole reviewer. See the AI Guidelines.

[rejaulalomkhan]

Thank you for the candid feedback and guidance, @t-hamano, and my sincere apologies for the noise!

You are completely right — while I ran the test suites locally to verify the pass, my note simply rephrased the diff rather than providing genuine critical evaluation or catching flaws. I take the WordPress AI Guidelines seriously, and I will make sure any future reviews are strictly reserved for when I have concrete technical critique, alternative approaches, or edge-case catches to offer.

Thank you for your leadership and patience!

[ericmann]

Thanks for picking this up so quickly. #15258 now requires WP_SECRETS_KEY and rejects any key equal to one of the keys and salts. An unfilled sample, translated or not, gives them all the same phrase, so that check covers the translated placeholder without __(). With __(), the result changes depending on whether the default textdomain is loaded yet, and on the user's locale. I think this can be closed once #15258 lands. Details are on the ticket.

[t-hamano]

@ericmann Thank you for pointing that out. I think your suggestion is more secure, so let's close this PR.