Skip to content

Secrets API: Mark internal helper functions as private. #14773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-hamano wants to merge 2 commits into from
Closed

Secrets API: Mark internal helper functions as private. #14773

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5362db
Secrets API: Mark internal helper functions as private.
t-hamano Oct 23, 2026
5e43d99
Merge branch 'trunk' into 66187-secrets-access-private
whyisjake Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/wp-includes/secrets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,7 @@ function wp_secrets_validate_name( string $name ) {
* be the exact silent downgrade this API refuses to make.
*
* @since 7.2.0
* @access private
*
* @global bool $wp_secrets_dropin_broken Whether the secrets.php drop-in failed to load cleanly.
* @global WP_Secrets_Store $wp_secrets_store Optional. Store override set by the drop-in.
Expand Down Expand Up @@ -356,6 +357,7 @@ function _wp_secrets_get_store(): WP_Secrets_Store {
* fails closed (WP_Secrets_Broken_Keyring) rather than falling back to the default.
*
* @since 7.2.0
* @access private
*
* @global bool $wp_secrets_dropin_broken Whether the secrets.php drop-in failed to load cleanly.
* @global WP_Secrets_Keyring $wp_secrets_keyring Optional. Keyring override set by the drop-in.
Expand Down Expand Up @@ -632,6 +634,7 @@ function wp_list_network_secrets( string $namespace = '' ) { // phpcs:ignore Uni
* to be empty.
*
* @since 7.2.0
* @access private
*
* @global bool $wp_secrets_dropin_broken Whether the secrets.php drop-in failed to load cleanly.
* @global WP_Secrets_Provider $wp_secrets_provider Optional. Provider override set by the drop-in.
Expand Down Expand Up @@ -781,6 +784,7 @@ function wp_secrets_provider_label(): string {
* Shared implementation behind wp_set_secret() and wp_set_network_secret().
*
* @since 7.2.0
* @access private
*
* @param string $name The secret's name.
* @param string $value The plaintext value.
Expand All @@ -805,6 +809,7 @@ function _wp_secrets_set(
* Shared implementation behind wp_get_secret() and wp_get_network_secret().
*
* @since 7.2.0
* @access private
*
* @param string $name The secret's name.
* @param string $version A WP_Secret_Version constant.
Expand Down Expand Up @@ -840,6 +845,7 @@ function _wp_secrets_get( string $name, string $version, bool $network ) {
* Shared implementation behind wp_delete_secret() and wp_delete_network_secret().
*
* @since 7.2.0
* @access private
*
* @param string $name The secret's name.
* @param bool $network Whether this is a network-scope secret.
Expand All @@ -853,6 +859,7 @@ function _wp_secrets_delete( string $name, bool $network ) {
* Shared implementation behind wp_retire_secret_version() and its network twin.
*
* @since 7.2.0
* @access private
*
* @param string $name The secret's name.
* @param bool $network Whether this is a network-scope secret.
Expand All @@ -866,6 +873,7 @@ function _wp_secrets_retire( string $name, bool $network ) {
* Shared implementation behind wp_list_secrets() and wp_list_network_secrets().
*
* @since 7.2.0
* @access private
*
* @param string $name_prefix Restrict to names beginning with this prefix.
* @param bool $network Whether to list network-scope secrets.
Expand Down
Loading