Repository navigation
Build/QA: Retire parameterByRef.unusedType baseline #14025
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| <?php | ||
| /** | ||
| * Unit tests covering _wp_scan_utf8(). | ||
| * | ||
| * @package WordPress | ||
| * @subpackage Charset | ||
| * | ||
| * @group compat | ||
| * | ||
| * @covers ::_wp_scan_utf8 | ||
| */ | ||
| class Tests_Compat_wpScanUtf8 extends WP_UnitTestCase { | ||
|
|
||
| /** | ||
| * Tests scanning a valid ASCII string. | ||
| * | ||
| * @ticket 65817 | ||
| */ | ||
| public function test_scan_ascii_string() { | ||
| $text = 'Hello, World!'; | ||
| $at = 0; | ||
| $invalid_length = 0; | ||
| $has_noncharacters = null; | ||
|
|
||
| $scanned = _wp_scan_utf8( $text, $at, $invalid_length, null, null, $has_noncharacters ); | ||
|
|
||
| $this->assertSame( 13, $scanned ); | ||
| $this->assertSame( 0, $invalid_length ); | ||
| $this->assertFalse( $has_noncharacters ); | ||
| } | ||
|
|
||
| /** | ||
| * Tests scanning UTF-8 string containing noncharacters. | ||
| * | ||
| * @ticket 65817 | ||
| * | ||
| * @dataProvider data_strings_with_noncharacters | ||
| * | ||
| * @param string $text UTF-8 string containing a noncharacter. | ||
| */ | ||
| public function test_scan_string_with_noncharacters( string $text ) { | ||
| $at = 0; | ||
| $invalid_length = 0; | ||
| $has_noncharacters = null; | ||
|
|
||
| _wp_scan_utf8( $text, $at, $invalid_length, null, null, $has_noncharacters ); | ||
|
|
||
| $this->assertTrue( $has_noncharacters ); | ||
| } | ||
|
|
||
| /** | ||
| * Data provider for noncharacters. | ||
| * | ||
| * @return array<string, array{0: string}> | ||
| */ | ||
| public static function data_strings_with_noncharacters() { | ||
| return array( | ||
| 'U+FFFF (3-byte noncharacter)' => array( "test \xEF\xBF\xBF end" ), | ||
| 'U+FFFE (3-byte noncharacter)' => array( "test \xEF\xBF\xBE end" ), | ||
| 'U+FDD0 (3-byte noncharacter)' => array( "test \xEF\xB7\x90 end" ), | ||
| 'U+1FFFF (4-byte noncharacter)' => array( "test \xF0\x9F\xBF\xBF end" ), | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Tests scanning UTF-8 string without noncharacters. | ||
| * | ||
| * @ticket 65817 | ||
| */ | ||
| public function test_scan_string_without_noncharacters() { | ||
|
Member
There was a problem hiding this comment. this is a misleading title. it would be clearer to show variant cases of multi-byte UTF-8 code points and extended grapheme clusters, which would clarify the behavior of the function. let’s use a data provider and show interesting cases, and then use this way we can cover two-, three-, and four-byte sequences, spans of invalid bytes (covering the maximal subpart behavior), ZWJ sequences, and grapheme clusters. |
||
| $text = 'WordPress: 日本語 and Piña!'; | ||
| $at = 0; | ||
| $invalid_length = 0; | ||
| $has_noncharacters = null; | ||
|
|
||
| _wp_scan_utf8( $text, $at, $invalid_length, null, null, $has_noncharacters ); | ||
|
|
||
| $this->assertFalse( $has_noncharacters ); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please verify that this doesn’t break the docs-generation. before we start changing
@paramdeclarations, we should ensure that the published docs page isn’t broken.you can hopefully lean on dmsnell#29 to figure out how to preview the generation.
I see that this is an additional annotation beyond the
@param, but it would be ideal to double-check first.